Skip to content

Avoid warning about result_fd being possibly uninitialized [blocks: #2310] #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2018

Conversation

tautschnig
Copy link
Collaborator

The default branch of the Windows version indeed did not initialize result_fd,
but is guarded by "UNREACHABLE".

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Nov 10, 2018
The default branch of the Windows version indeed did not initialize result_fd,
but is guarded by "UNREACHABLE".
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 985125a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90941469

@tautschnig tautschnig merged commit 386ea88 into diffblue:develop Nov 10, 2018
@tautschnig tautschnig deleted the vs-uninit branch November 10, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants